Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the mousekey scrolling #9174

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Fix the mousekey scrolling #9174

merged 1 commit into from
Jul 16, 2020

Conversation

dhong44
Copy link
Contributor

@dhong44 dhong44 commented May 23, 2020 •
edited
Loading

Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dhong44
Fix the mousekey scrolling
9bb4a8e 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
@drashna drashna requested a review from a team May 24, 2020 21:22
@dhong44
Copy link
Contributor Author

dhong44 commented Jun 18, 2020

Hi, just wondering if I could get a review on this?

@drashna drashna requested a review from a team July 2, 2020 03:11
@fauxpark
Copy link
Member

fauxpark commented Jul 2, 2020

This may need to go through develop.

@drashna drashna changed the base branch from master to develop July 8, 2020 13:11
@tzarc tzarc merged commit 5a4ec42 into qmk:develop Jul 16, 2020
noroadsleft pushed a commit that referenced this pull request Jul 18, 2020
@dhong44 @noroadsleft
Fix the mousekey scrolling (#9174)
dca6cee 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
noroadsleft pushed a commit that referenced this pull request Jul 26, 2020
@dhong44 @noroadsleft
Fix the mousekey scrolling (#9174)
149896a 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
noroadsleft pushed a commit that referenced this pull request Jul 31, 2020
@dhong44 @noroadsleft
Fix the mousekey scrolling (#9174)
17cdd90 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
@dhong44 @noroadsleft
Fix the mousekey scrolling (#9174)
31a0264 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
@dhong44 @noroadsleft
Fix the mousekey scrolling (#9174)
e8ceaad 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
@dhong44 @noroadsleft
Fix the mousekey scrolling (#9174)
d0abad2 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@dhong44 @nicocesar
Fix the mousekey scrolling (qmk#9174)
d9b01f0 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
@dhong44 dhong44 mentioned this pull request Sep 18, 2020
Closed
@dhong44 dhong44 deleted the mousekey_scroll_fix branch September 18, 2020 04:56
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
@dhong44 @drashna
Fix the mousekey scrolling (qmk#9174)
b3363f4 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@dhong44 @noroadsleft
Fix the mousekey scrolling (qmk#9174)
8f44ff4 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@dhong44 @noroadsleft
Fix the mousekey scrolling (qmk#9174)
5648be1 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhong44 @fauxpark @drashna @tzarc @noroadsleft